Skip to content

bpo-33336: Legalize MOVE command #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 3 commits into from
Jul 23, 2018
Merged

bpo-33336: Legalize MOVE command #6569

vstinner merged 3 commits into from
Jul 23, 2018

Conversation

@mcepl
Copy link
Contributor

@mcepl mcepl commented Apr 22, 2018 •
edited by bedevere-bot
Loading

Just checking whether this is a good idea at all. If so, I will add metadata required.

https://bugs.python.org/issue33336

@mcepl mcepl requested a review from a team as a code owner April 22, 2018 22:43
@vstinner vstinner requested a review from warsaw June 4, 2018 15:07
@mcepl
Copy link
Contributor Author

mcepl commented Jun 4, 2018

I would love to eventually have some way how to make moving messages universally possible (https://bugs.python.org/issue33327), but this is the least what I can hope for.

vstinner
vstinner reviewed Jun 4, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a ".. versionchanged:: 3.7" markup near https://docs.python.org/dev/library/imaplib.html#imaplib.IMAP4.uid (Doc/library/imaplib.rst) to document that MOVE is now supported.

@mcepl
Copy link
Contributor Author

mcepl commented Jun 21, 2018 •
edited
Loading

You should add a ".. versionchanged:: 3.7" markup near https://docs.python.org/dev/library/imaplib.html#imaplib.IMAP4.uid (Doc/library/imaplib.rst) to document that MOVE is now supported.

@vstinner I still hold that this is not change in API. We never documented which IMAP commands are supported in IMAP4.uid, so there is no change in documentation.

I would like this bugfix be ported to other older versions of Python, which won't happen for change of API.

And yes, if calling this bugfix as change of API makes you stop stalling merging of this PR (I thought we went through all this on IRC, but apparently that discussion didn't change anything), I am willing to shut up and let it be limited to 3.8. Better that than nothing.

vstinner
vstinner approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't know the IMAP protocol nor the imaplib module. I would be more confortable if someone from the "email team", @warsaw or someone else review this PR. But this PR was created in April, 3 monhs ago, and didn't get any review whereas the PR looks safe and good (to me).

I suggest to backport the change to 2.7, 3.6 and 3.7 branches.

I will merge this PR next week except if someone show up against it.

Misc/NEWS.d/next/Library/2018-04-27-22-18-38.bpo-33336.T8rxn0.rst Outdated
@@ -0,0 +1,2 @@
``imaplib`` now allows ``MOVE`` command in ``IMAP4.uid()`` and potentially
as a name of supported method of ``IMAP4`` object.
Copy link
Member

@vstinner vstinner Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to add a reference to the RFC 6851? Example:

imaplib now allows MOVE command in IMAP4.uid() (RFC 6851: IMAP MOVE Extension)
and potentially as a name of supported method of IMAP4 object.

@vstinner
Copy link
Member

vstinner commented Jul 19, 2018

@bitdancer, @warsaw: Would you mind to review this imaplib PR?

@bedevere-bot
Copy link

bedevere-bot commented Jul 21, 2018

GH-8370 is a backport of this pull request to the 2.7 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 21, 2018

GH-8373 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 21, 2018

GH-8386 is a backport of this pull request to the 3.7 branch.

@vstinner vstinner merged commit caa331d into python:master Jul 23, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Jul 23, 2018

Thanks @mcepl for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2018
@mcepl @miss-islington
bpo-33336, imaplib: Legalize MOVE command (pythonGH-6569)
9643d3c 
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851:
IMAP MOVE Extension) and potentially as a name of supported
method of IMAP4 object.
(cherry picked from commit caa331d)

Co-authored-by: Matěj Cepl <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jul 23, 2018

GH-8409 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 23, 2018

GH-8410 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2018
@mcepl @miss-islington
bpo-33336, imaplib: Legalize MOVE command (pythonGH-6569)
f52967b 
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851:
IMAP MOVE Extension) and potentially as a name of supported
method of IMAP4 object.
(cherry picked from commit caa331d)

Co-authored-by: Matěj Cepl <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jul 23, 2018

GH-8411 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2018
@mcepl @miss-islington
bpo-33336, imaplib: Legalize MOVE command (pythonGH-6569)
8086aff 
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851:
IMAP MOVE Extension) and potentially as a name of supported
method of IMAP4 object.
(cherry picked from commit caa331d)

Co-authored-by: Matěj Cepl <[email protected]>
@mcepl mcepl deleted the 33336_legalize_move_command branch July 23, 2018 12:46
miss-islington added a commit that referenced this pull request Jul 23, 2018
@miss-islington @mcepl
bpo-33336, imaplib: Legalize MOVE command (GH-6569)
1127849 
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851:
IMAP MOVE Extension) and potentially as a name of supported
method of IMAP4 object.
(cherry picked from commit caa331d)

Co-authored-by: Matěj Cepl <[email protected]>
vstinner pushed a commit that referenced this pull request Jul 23, 2018
@miss-islington @mcepl @vstinner
bpo-33336, imaplib: Legalize MOVE command (GH-6569) (GH-8409)
96bba04 
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851:
IMAP MOVE Extension) and potentially as a name of supported
method of IMAP4 object.
(cherry picked from commit caa331d)

Co-authored-by: Matěj Cepl <[email protected]>
miss-islington added a commit that referenced this pull request Jul 23, 2018
@miss-islington @mcepl
bpo-33336, imaplib: Legalize MOVE command (GH-6569)
7868426 
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851:
IMAP MOVE Extension) and potentially as a name of supported
method of IMAP4 object.
(cherry picked from commit caa331d)

Co-authored-by: Matěj Cepl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcepl @vstinner @bedevere-bot @miss-islington @the-knights-who-say-ni