bpo-33041: Fix downcast warning on Windows #6595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast pointer difference from ssize_t to int: a frame is very unlikely larger than 2 GB.
Member
Author
|
I'm not sure about silently downcasting ssize_t to int. Maybe a check at runtime would be safer, but I'm too lazy to write complex code to handle errors :-) What do you think @serhiy-storchaka? Is it ok to rely that a stack will not be larger than 2 GB? |
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I think it is safe. This difference should be limited by co_stacksize which has type int.
serhiy-storchaka
approved these changes
Apr 25, 2018
Member
Author
Oh right. Thanks for checking! |
|
@vstinner: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast pointer difference from ssize_t to int: a frame is very unlikely
larger than 2 GB.
https://bugs.python.org/issue33041