bpo-28167: bump Deprecated function removal to 3.8 #6669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bump PendingDeprecationWarning to DeprecationWarning.
Contributor
Author
|
Not sure if requires a News item. If so can a |
Contributor
Author
|
Hum, looking at https://bugs.python.org/issue26041 from 2 years ago, it might also be possible to just delete the mention of removal in a future version. |
vstinner
approved these changes
May 2, 2018
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the link to the distro package!
Member
Please add a News entry. It's always a good idea to document deprecated features :-) IMHO it would also help to document in What's New in Python 3.7 that platform.linux_distribution() is deprecated and will be removed from Python 3.8. |
Contributor
Author
Done: The deprecation was already announced in 3.5 NEWS: |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 15, 2018
…6669) Also bump PendingDeprecationWarning to DeprecationWarning. (cherry picked from commit 9eb40bc) Co-authored-by: Matthias Bussonnier <[email protected]>
|
GH-6862 is a backport of this pull request to the 3.7 branch. |
encukou
pushed a commit
that referenced
this pull request
May 15, 2018
…H-6862) Also bump PendingDeprecationWarning to DeprecationWarning. (cherry picked from commit 9eb40bc) Co-authored-by: Matthias Bussonnier <[email protected]>
Contributor
Author
|
Thanks ! |
encukou
added a commit
to encukou/distro
that referenced
this pull request
May 16, 2018
The distro package is now recommended in Python documentation as a replacement for `platform.linux_distribution`. See: * https://docs.python.org/3.7/library/platform.html#platform.linux_distribution * python/cpython#6669 Also, `platform.linux_distribution` is removed from Python 3.8 (which is not released yet). See: * https://docs.python.org/3.8/library/platform.html * python/cpython#6871 Reflect this in `distro`'s README and docstring.
nir0s
pushed a commit
to python-distro/distro
that referenced
this pull request
May 17, 2018
The distro package is now recommended in Python documentation as a replacement for `platform.linux_distribution`. See: * https://docs.python.org/3.7/library/platform.html#platform.linux_distribution * python/cpython#6669 Also, `platform.linux_distribution` is removed from Python 3.8 (which is not released yet). See: * https://docs.python.org/3.8/library/platform.html * python/cpython#6871 Reflect this in `distro`'s README and docstring.
nir0s
pushed a commit
to python-distro/distro
that referenced
this pull request
Feb 2, 2019
The distro package is now recommended in Python documentation as a replacement for `platform.linux_distribution`. See: * https://docs.python.org/3.7/library/platform.html#platform.linux_distribution * python/cpython#6669 Also, `platform.linux_distribution` is removed from Python 3.8 (which is not released yet). See: * https://docs.python.org/3.8/library/platform.html * python/cpython#6871 Reflect this in `distro`'s README and docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump PendingDeprecationWarning to DeprecationWarning.
I'm guessing we are far enough in the cycle that it's too late for removal...
https://bugs.python.org/issue28167