[3.7] bpo-32861: urllib.robotparser fix incomplete __str__ methods. (GH-5711) #6795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GH-5711) The urllib.robotparser's __str__ representation now includes wildcard entries and the "Crawl-delay" and "Request-rate" fields. Also removes extra newlines that were being appended to the end of the string. (cherry picked from commit bd08a0a) Co-authored-by: Michael Lazar <[email protected]>
bedevere-bot
added
type-bug
Contributor
Author
|
Thanks @miss-islington for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6. |
Contributor
Author
|
Thanks, @serhiy-storchaka! |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
May 14, 2018
…ythonGH-5711) (pythonGH-6795) The urllib.robotparser's __str__ representation now includes wildcard entries and the "Crawl-delay" and "Request-rate" fields. (cherry picked from commit bd08a0a) Co-authored-by: Michael Lazar <[email protected]> (cherry picked from commit c3fa1f2) Co-authored-by: Miss Islington (bot) <[email protected]>
Contributor
Author
|
Sorry, @miss-islington and @serhiy-storchaka, I could not cleanly backport this to |
Member
|
This should not have the backport labels. |
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 14, 2018
…ythonGH-5711) (pythonGH-6795) The robotparser's __str__ representation now includes wildcard entries. (cherry picked from commit c3fa1f2) Co-authored-by: Michael Lazar <[email protected]>.
Member
|
I have added the backport labels because the modified vwrsion should be backported to maintained releases. I modified this PR and set labels for half-automatic backporting to 3.6 and 2.7. |
Contributor
Author
|
Thanks @miss-islington for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
May 14, 2018
…ythonGH-5711) (pythonGH-6795) The urllib.robotparser's __str__ representation now includes wildcard entries and the "Crawl-delay" and "Request-rate" fields. (cherry picked from commit bd08a0a) Co-authored-by: Michael Lazar <[email protected]> (cherry picked from commit c3fa1f2) Co-authored-by: Miss Islington (bot) <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
May 14, 2018
…H-5711) (GH-6795) (GH-6818) The urllib.robotparser's __str__ representation now includes wildcard entries and the "Crawl-delay" and "Request-rate" fields. (cherry picked from commit c3fa1f2) Co-authored-by: Michael Lazar <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
May 14, 2018
GH-6795) (GH-6817) The robotparser's __str__ representation now includes wildcard entries. (cherry picked from commit c3fa1f2) Co-authored-by: Michael Lazar <[email protected]>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The urllib.robotparser's
__str__representation now includes wildcard entries and the "Crawl-delay" and "Request-rate" fields.(cherry picked from commit bd08a0a)
Co-authored-by: Michael Lazar [email protected]
https://bugs.python.org/issue32861