bpo-33421: Add AsyncContextManager to typing module documentation (Python 3.6). #6823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
May 14, 2018
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! Only one comment.
Doc/library/typing.rst
Outdated
Member
There was a problem hiding this comment.
I would make this :meth:``__aenter__`` etc.
Contributor
Author
|
Fixed! |
matrixise
approved these changes
May 14, 2018
ilevkivskyi
reviewed
May 14, 2018
Doc/library/typing.rst
Outdated
Member
There was a problem hiding this comment.
Sorry for giving you a wrong advice, it actually should be :meth:`__aiter__` (single backticks). You can also try make html and check that they are rendered correctly in docs.
Contributor
Author
There was a problem hiding this comment.
Should have caught it myself. Fixed it and built it and works as expected. 🎉
ilevkivskyi
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documention for
typing.AsyncContextManagerfor Python 3.6.See #6700.
@ilevkivskyi
https://bugs.python.org/issue33421