Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

  • Set the limited API version for PyImport_GetModule and PyOS_*Fork functions.
  • Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
  • Add several functions in Doc/data/refcounts.dat.

* Set the limited API version for PyImport_GetModule and PyOS_*Fork
  functions.
* Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
* Add several functions in Doc/data/refcounts.dat.
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this! Sorry I missed it.

@serhiy-storchaka serhiy-storchaka merged commit 4e29f56 into python:master May 22, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4e29f566e8821c09d8274eadcdd355e8b1284b8b 3.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 22, 2018
* Set the limited API version for PyImport_GetModule and PyOS_*Fork
  functions.
* Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
* Add several functions in Doc/data/refcounts.dat..
(cherry picked from commit 4e29f56)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-7061 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request May 22, 2018
…H-7061)

* Set the limited API version for PyImport_GetModule and PyOS_*Fork
  functions.
* Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
* Add several functions in Doc/data/refcounts.dat.
(cherry picked from commit 4e29f56)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants