Skip to content

bpo-33652: Improve pickle support in the typing module. #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilevkivskyi merged 1 commit into from
May 26, 2018
Merged

bpo-33652: Improve pickle support in the typing module. #7123

ilevkivskyi merged 1 commit into from
May 26, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 26, 2018 •
edited by bedevere-bot
Loading

Pickles of type variables and subscripted generics are now future-proof and compatible with older Python versions.

https://bugs.python.org/issue33652

@serhiy-storchaka
bpo-33652: Improve pickle support in the typing module.
57b65ae 
Pickles of type variables and subscripted generics are now future-proof
and compatible with older Python versions.
ilevkivskyi
ilevkivskyi reviewed May 26, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't see any problems with this implementation. Only one concern is operator module loading time. People complained that typing slows down application startup, and operator is not that often imported nowadays. Did you make any measurements of import time with this PR?

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented May 26, 2018

The import time of typing varies from 8.3 to 9.7 ms (when run ./python -X importtime -c 'import typing' several times sequentially). Importing operator takes 0.35 ms (around 4% of total time), but it is imported by collections in any case, and therefore this PR doesn't affect the import time.

ilevkivskyi
ilevkivskyi approved these changes May 26, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it is imported by collections in any case, and therefore this PR doesn't affect the import time.

Ah, OK then!

@ned-deily ned-deily removed their request for review May 26, 2018 12:56
@ned-deily
Copy link
Member

ned-deily commented May 26, 2018

I'm OK with merging this for 3.7 if @ilevkivskyi and/or @gvanrossum are/is.

@ilevkivskyi
Copy link
Member

ilevkivskyi commented May 26, 2018 •
edited
Loading

I am fine with backporting this to 3.7.

@gvanrossum
Copy link
Member

gvanrossum commented May 26, 2018

Yes, fine with me to for the backport.

@ilevkivskyi ilevkivskyi merged commit 09f3221 into python:master May 26, 2018
@miss-islington
Copy link
Contributor

miss-islington commented May 26, 2018

Thanks @serhiy-storchaka for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 26, 2018

GH-7132 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2018
@serhiy-storchaka @miss-islington
bpo-33652: Improve pickle support in the typing module. (pythonGH-7123)
46fcdec 
Pickles of type variables and subscripted generics are now future-proof
and compatible with older Python versions.
(cherry picked from commit 09f3221)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request May 26, 2018
@miss-islington @serhiy-storchaka
bpo-33652: Improve pickle support in the typing module. (GH-7123)
d498625 
Pickles of type variables and subscripted generics are now future-proof
and compatible with older Python versions.
(cherry picked from commit 09f3221)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka deleted the typing-pickle branch July 7, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@serhiy-storchaka @ned-deily @ilevkivskyi @gvanrossum @miss-islington @bedevere-bot @the-knights-who-say-ni