bpo-31647: Fix write_eof() after close() for SelectorSocketTransport #7149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug where calling write_eof() on a _SelectorSocketTransport after it's already closed raises AttributeError.
Added a test case for calling write_eof() after close() on _SelectorSocketTransport.
twisteroidambassador
changed the title
Contributor
Author
|
Whoooooooops. Fat finger, I wrote the issue number wrong. (facepalm) The correct number is bpo-31647. I have corrected the title. I see there's an issue number tag in the first comment, should I edit that one as well? Are there too much bot magic here that I should simply close this PR and make a new one? |
1st1
approved these changes
May 28, 2018
Contributor
|
Thanks @twisteroidambassador for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Member
|
Thanks @twisteroidambassador! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2018
…ythonGH-7149) Fixed bug where calling write_eof() on a _SelectorSocketTransport after it's already closed raises AttributeError. (cherry picked from commit 23f587e) Co-authored-by: twisteroid ambassador <[email protected]>
|
GH-7153 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2018
…ythonGH-7149) Fixed bug where calling write_eof() on a _SelectorSocketTransport after it's already closed raises AttributeError. (cherry picked from commit 23f587e) Co-authored-by: twisteroid ambassador <[email protected]>
|
GH-7154 is a backport of this pull request to the 3.6 branch. |
1st1
pushed a commit
that referenced
this pull request
May 28, 2018
…H-7149) (GH-7153) Fixed bug where calling write_eof() on a _SelectorSocketTransport after it's already closed raises AttributeError. (cherry picked from commit 23f587e) Co-authored-by: twisteroid ambassador <[email protected]>
1st1
pushed a commit
that referenced
this pull request
May 28, 2018
…H-7149) (#7154) Fixed bug where calling write_eof() on a _SelectorSocketTransport after it's already closed raises AttributeError. (cherry picked from commit 23f587e) Co-authored-by: twisteroid ambassador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where calling write_eof() on a _SelectorSocketTransport after
it's already closed raises AttributeError. Also added a test case for this behavior.
https://bugs.python.org/issue31647