bpo-33674: asyncio: Fix SSLProtocol race #7175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race condition in SSLProtocol.connection_made() of asyncio.sslproto: start immediately the handshake instead of using call_soon(). Previously, data_received() could be called before the handshake started, causing the handshake to hang or fail.
1st1
approved these changes
May 28, 2018
Create self._handshake_timeout_handle before calling _process_write_backlog().
1st1
added a commit
to MagicStack/uvloop
that referenced
this pull request
May 28, 2018
Relevant CPython PR: python/cpython#7175
1st1
added a commit
to MagicStack/uvloop
that referenced
this pull request
May 28, 2018
Relevant CPython PR: python/cpython#7175
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2018
Fix a race condition in SSLProtocol.connection_made() of asyncio.sslproto: start immediately the handshake instead of using call_soon(). Previously, data_received() could be called before the handshake started, causing the handshake to hang or fail. (cherry picked from commit be00a55) Co-authored-by: Victor Stinner <[email protected]>
|
GH-7187 is a backport of this pull request to the 3.7 branch. |
Contributor
|
Sorry, @vstinner, I could not cleanly backport this to |
|
GH-7188 is a backport of this pull request to the 3.6 branch. |
ned-deily
pushed a commit
that referenced
this pull request
May 29, 2018
Fix a race condition in SSLProtocol.connection_made() of asyncio.sslproto: start immediately the handshake instead of using call_soon(). Previously, data_received() could be called before the handshake started, causing the handshake to hang or fail. (cherry picked from commit be00a55) Co-authored-by: Victor Stinner <[email protected]>
1st1
pushed a commit
that referenced
this pull request
May 29, 2018
Fix a race condition in SSLProtocol.connection_made() of asyncio.sslproto: start immediately the handshake instead of using call_soon(). Previously, data_received() could be called before the handshake started, causing the handshake to hang or fail. (cherry picked from commit be00a55)
Olaf1022
pushed a commit
to Olaf1022/Ultra-fast-asyncio
that referenced
this pull request
Aug 13, 2023
Relevant CPython PR: python/cpython#7175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition in SSLProtocol.connection_made() of
asyncio.sslproto: start immediately the handshake instead of using
call_soon(). Previously, data_received() could be called before the
handshake started, causing the handshake to hang or fail.
https://bugs.python.org/issue33674