Skip to content

[3.6] bpo-31234: Add test.support.wait_threads_exit() (GH-3578) #7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Jun 1, 2018
Merged

[3.6] bpo-31234: Add test.support.wait_threads_exit() (GH-3578) #7315

vstinner merged 2 commits into from
Jun 1, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 1, 2018 •
edited by bedevere-bot
Loading

vstinner added 2 commits June 1, 2018 14:12
@vstinner
bpo-31234: Add test.support.wait_threads_exit() (GH-3578)
e95c7fc 
Use _thread.count() to wait until threads exit. The new context
manager prevents the "dangling thread" warning.

(cherry picked from commit ff40ecd)
@vstinner
bpo-31234: Try to fix lock_tests warning (#3557)
a01aeb7 
Try to fix the "Warning -- threading_cleanup() failed to cleanup 1
threads" warning in test.lock_tests: wait a little bit longer to give
time to the threads to complete.

Warning seen on test_thread and test_importlib.

(cherry picked from commit 096ae33)
@vstinner vstinner merged commit 5dbb48a into python:3.6 Jun 1, 2018
@vstinner vstinner deleted the wait_threads_exit36 branch June 1, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot