bpo-33476: Fix _header_value_parser.py when address group is missing final ';' #7484
Conversation
corona10
force-pushed
the
bpo-33476
branch
3 times, most recently
from
641ab12 to
12c2425
Compare
|
@bitdancer Please take a look 👍 |
Lib/test/test_email/test_parser.py
Outdated
There was a problem hiding this comment.
I'd prefer a test in test__header_value_parser, since that's the module that's being changed. Specifically, if you search the file for "# get_group" you'll see the set of tests for the function this PR modifies. Put the test in there.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@bitdancer |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
|
@bitdancer |
zooba
dismissed
bitdancer’s stale review
The changes have been made according to the request.
…al ';' (pythonGH-7484) (cherry picked from commit 8fe9eed) Co-authored-by: Dong-hee Na <[email protected]>
|
GH-8522 is a backport of this pull request to the 3.7 branch. |
…al ';' (pythonGH-7484) (cherry picked from commit 8fe9eed) Co-authored-by: Dong-hee Na <[email protected]>
|
GH-8524 is a backport of this pull request to the 3.6 branch. |
…al ';' (GH-7484) (cherry picked from commit 8fe9eed) Co-authored-by: Dong-hee Na <[email protected]>
…al ';' (GH-7484) (cherry picked from commit 8fe9eed) Co-authored-by: Dong-hee Na <[email protected]>
6 participants
Fix _header_value_parser.py when address group is missing final ';'
Need to backport patch for 3.7, 3.6.
https://bugs.python.org/issue33476