bpo-33824, bpo-32030: Fix pymain_read_conf() #7712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned-deily
approved these changes
Jun 15, 2018
Member
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Fixes the problem, thanks! The NEWS item is a little unclear, though. Maybe don't use two "when"s?
Fix "LC_ALL=C python3.7 -V": reset properly the command line parser when the encoding changes after reading the Python configuration. Fix pymain_read_conf(): use memset(0) to reset properly cmdline.
Member
Author
|
I rephrased the NEWS entry. |
ned-deily
approved these changes
Jun 15, 2018
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-7730 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2018
Fix "LC_ALL=C python3.7 -V": reset properly the command line parser when the encoding changes after reading the Python configuration. Fix pymain_read_conf(): use memset(0) to reset properly cmdline. (cherry picked from commit 6c5a4b3) Co-authored-by: Victor Stinner <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 15, 2018
Fix "LC_ALL=C python3.7 -V": reset properly the command line parser when the encoding changes after reading the Python configuration. Fix pymain_read_conf(): use memset(0) to reset properly cmdline. (cherry picked from commit 6c5a4b3) Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "LC_ALL=C python3.7 -V": fix code parsing command line arguments when
the encoding changes when reading the Python configuration.
Fix pymain_read_conf(): use memset(0) to reset properly cmdline.
https://bugs.python.org/issue33824