bpo-33901: Better test_dbm_gnu.test_reorganize() fix #7795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test_dbm_gnu.test_reorganize() on macOS with gdbm 1.15: add a larger value to make sure that the file size changes.
Member
Author
|
@serhiy-storchaka: Is that better? |
Lib/test/test_dbm_gnu.py
Outdated
| # bpo-33901: on macOS with gdbm 1.15, an empty database uses 16 MiB | ||
| # and adding an entry of 10,000 B has no effect on the file size. | ||
| # Add size0//2 bytes to make sure that the file size changes. | ||
| value_size = max(size0 // 2, 10000) |
Member
There was a problem hiding this comment.
Why not size0? This will guarantee that the file size will be increased (unless the database uses a compression, that is unlikely).
Member
Author
There was a problem hiding this comment.
I modified my PR to use size0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test_dbm_gnu.test_reorganize() on macOS with gdbm 1.15: add a
larger value to make sure that the file size changes.
https://bugs.python.org/issue33901