bpo-33975: Avoid small type when running IDLE's htests. #7944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import pyshell to call SetProcessDpiAwareness on Windows before tkinter.Tk() is called in the same process.
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2018
Import pyshell first in htest to call SetProcessDpiAwareness on Windows before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()' undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots, a unittest before an htest does not require anything more to work right. Since part of the purpose of human-viewed tests is to determine that widgets look right, it is important that they look the same for testing as when running IDLE. (cherry picked from commit 3c8043d) Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-7951 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2018
Import pyshell first in htest to call SetProcessDpiAwareness on Windows before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()' undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots, a unittest before an htest does not require anything more to work right. Since part of the purpose of human-viewed tests is to determine that widgets look right, it is important that they look the same for testing as when running IDLE. (cherry picked from commit 3c8043d) Co-authored-by: Terry Jan Reedy <[email protected]>
|
GH-7952 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 27, 2018
Import pyshell first in htest to call SetProcessDpiAwareness on Windows before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()' undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots, a unittest before an htest does not require anything more to work right. Since part of the purpose of human-viewed tests is to determine that widgets look right, it is important that they look the same for testing as when running IDLE. (cherry picked from commit 3c8043d) Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 27, 2018
Import pyshell first in htest to call SetProcessDpiAwareness on Windows before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()' undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots, a unittest before an htest does not require anything more to work right. Since part of the purpose of human-viewed tests is to determine that widgets look right, it is important that they look the same for testing as when running IDLE. (cherry picked from commit 3c8043d) Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import pyshell first in htest to call SetProcessDpiAwareness on Windows
before tkinter.Tk() is called for the htest. Apparently, 'root.destroy()'
undoes a previous 'root = Tk()'. Since IDLE unittests always destroy roots,
a unittest before an htest does not require anything more to work right.
Since part of the purpose of human-viewed tests is to determine that
widgets look right, it is important that they look the same for testing
as when running IDLE.
https://bugs.python.org/issue33975