bpo-25803: Avoid incorrect errors raised by Path.mkdir(exist_ok=True) #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the OS gives priority to errors such as EACCES over EEXIST.
serhiy-storchaka
added
type-bug
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @zooba and @warsaw to be potential reviewers. |
brettcannon
approved these changes
Mar 24, 2017
| fd = self._raw_open(flags, mode) | ||
| os.close(fd) | ||
|
|
||
| def mkdir(self, mode=0o777, parents=False, exist_ok=False): |
Member
There was a problem hiding this comment.
Could you quickly add a docstring? Maybe "Create a new directory at this given path."?
A more thorough one is probably even better explaining the parameters, but the one-liner is better than nothing.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 24, 2017
…python#805) when the OS gives priority to errors such as EACCES over EEXIST. (cherry picked from commit af7b9ec)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 24, 2017
…python#805) when the OS gives priority to errors such as EACCES over EEXIST. (cherry picked from commit af7b9ec)
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 24, 2017
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the OS gives priority to errors such as EACCES over EEXIST.