bpo-34006: Set SPHINXOPTS for htmlhelp #8051
Conversation
Specifically, set html_theme_options.body_max_width=none
Doc/make.bat
Outdated
| if NOT "%2" EQU "" ( | ||
| echo.Can't specify filenames to build with htmlview target, ignoring. | ||
| ) | ||
| set SPHINXOPTS=-D html_theme_options.body_max_width=none %SPHINXOPTS% |
There was a problem hiding this comment.
htmlview is the wrong target; it makes html in the default location and views the result in the default browser.
But the new line works in that the line limit is gone in the resulting html. So the new line just needs to go somewhere else.
I tried moving the new line up under 136 if "%1" EQU "htmlhelp" ( but that failed. I believe this is because the html has already been built by Sphinx with the line limit and the next step just compresses the html as is into the .chm. I will try putting the addition guarded by the same if somewhere up above.
There was a problem hiding this comment.
I found the right place, a couple of line up, before cmd.... Preparing blurb.
There was a problem hiding this comment.
Sorry about that, I managed to misread pretty terribly. Fixed; still not tested.
|
Does the news item look ok to you? also as commit message? |
|
Looks fine to me. |
|
Thanks @zware for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-8053 is a backport of this pull request to the 3.7 branch. |
) The line-length limit is not needed because the pages appear in a separate app rather than on a browser tab. It can also interact badly with the DPI setting. (cherry picked from commit d824ca7) Co-authored-by: Zachary Ware <[email protected]>
|
GH-8054 is a backport of this pull request to the 3.6 branch. |
) The line-length limit is not needed because the pages appear in a separate app rather than on a browser tab. It can also interact badly with the DPI setting. (cherry picked from commit d824ca7) Co-authored-by: Zachary Ware <[email protected]>
The line-length limit is not needed because the pages appear in a separate app rather than on a browser tab. It can also interact badly with the DPI setting. (cherry picked from commit d824ca7) Co-authored-by: Zachary Ware <[email protected]>
The line-length limit is not needed because the pages appear in a separate app rather than on a browser tab. It can also interact badly with the DPI setting. (cherry picked from commit d824ca7) Co-authored-by: Zachary Ware <[email protected]>
5 participants
Specifically, set html_theme_options.body_max_width=none
https://bugs.python.org/issue34006