Skip to content

bpo-26544: Get rid of dependence from distutils in platform. #8356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 3 commits into from
Aug 27, 2018
Merged

bpo-26544: Get rid of dependence from distutils in platform. #8356

serhiy-storchaka merged 3 commits into from
Aug 27, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 20, 2018 •
edited by bedevere-bot
Loading

malemburg
malemburg reviewed Aug 21, 2018
View reviewed changes
Lib/platform.py Outdated
# http://php.net/manual/en/function.version-compare.php

_ver_stages = {
# any string not found in this dict
Copy link
Member

@malemburg malemburg Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the comment should read: "any string not found in this dict, will get 0 assigned" or something similar.

Copy link
Member Author

@serhiy-storchaka serhiy-storchaka Aug 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. Done.

@serhiy-storchaka serhiy-storchaka merged commit 7d81e8f into python:master Aug 27, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Aug 27, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the platform-version-compare branch August 27, 2018 10:29
@miss-islington
Copy link
Contributor

miss-islington commented Aug 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7d81e8f5995df6980a1a02923e224a481375f130 3.7

@miss-islington
Copy link
Contributor

miss-islington commented Aug 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7d81e8f5995df6980a1a02923e224a481375f130 3.6

@bedevere-bot
Copy link

bedevere-bot commented Aug 27, 2018

GH-8952 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2018
@serhiy-storchaka @miss-islington
bpo-26544: Get rid of dependence from distutils in platform. (pythonG…
2a884c7 
…H-8356)

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 28, 2018
@serhiy-storchaka
[3.7] bpo-26544: Get rid of dependence from distutils in platform. (p…
3545200 
…ythonGH-8356).

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Aug 28, 2018

GH-8970 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 28, 2018
@serhiy-storchaka
[3.6] bpo-26544: Get rid of dependence from distutils in platform. (p…
0d895b1 
…ythonGH-8356).

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Aug 28, 2018

GH-8971 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit that referenced this pull request Sep 4, 2018
@serhiy-storchaka
[3.7] bpo-26544: Get rid of dependence from distutils in platform. (G…
20a8392 
…H-8356). (GH-8970)

(cherry picked from commit 7d81e8f)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2018
@serhiy-storchaka @miss-islington
[3.7] bpo-26544: Get rid of dependence from distutils in platform. (p…
1a638dd 
…ythonGH-8356). (pythonGH-8970)

(cherry picked from commit 7d81e8f)
(cherry picked from commit 20a8392)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 4, 2018
@serhiy-storchaka
[2.7] [3.7] bpo-26544: Get rid of dependence from distutils in platfo…
01a4222 
…rm. (pythonGH-8356). (pythonGH-8970)

(cherry picked from commit 7d81e8f).
(cherry picked from commit 20a8392)

Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner pushed a commit that referenced this pull request Sep 5, 2018
@miss-islington @serhiy-storchaka @vstinner
[3.7] bpo-26544: Get rid of dependence from distutils in platform. (G…
1a3eb12 
…H-8356) (GH-8970) (GH-9061)

(cherry picked from commit 7d81e8f)
(cherry picked from commit 20a8392)

Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner pushed a commit that referenced this pull request Sep 5, 2018
@miss-islington @serhiy-storchaka @vstinner
bpo-26544: Get rid of dependence from distutils in platform. (GH-8356) (
9734024 
GH-8952)

(cherry picked from commit 7d81e8f)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malemburg malemburg malemburg left review comments

@doko42 doko42 Awaiting requested review from doko42

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @malemburg @the-knights-who-say-ni