-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-34317:Improve docstring windows.rst Environment variables in Windows NT #8622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request You can check yourself Thanks again for your contribution, we look forward to reviewing it! |
|
I seem to be blocked on "CLA not signed". The CPython devguide says: {"HiyashiChuka":true} Please let me know if there's anything that needs correcting. |
|
Thanks @HiyashiChuka for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-8640 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @HiyashiChuka and @Mariatta, I could not cleanly backport this to |
(cherry picked from commit 46ebe61) Co-authored-by: HiyashiChuka <[email protected]>
|
Thanks @HiyashiChuka and congrats on your first contribution to CPython 🌮 |
(cherry picked from commit 46ebe61) Co-authored-by: HiyashiChuka <[email protected]>
Expired link in windows.rst:
https://support.microsoft.com/en-us/help/100843/environment-variables-in-windows-nt
May I make a suggestion?
The new link:https://www.microsoft.com/en-us/wdsi/help/folder-variables
https://bugs.python.org/issue34317