Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 2, 2018

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 2, 2018
@ghost
Copy link
Author

ghost commented Aug 2, 2018

I seem to be blocked on "CLA not signed". The CPython devguide says:
I've signed and submitted the CLA.

{"HiyashiChuka":true}
https://bugs.python.org/user?@template=clacheck&github_names=HiyashiChuka

Please let me know if there's anything that needs correcting.

@miss-islington
Copy link
Contributor

Thanks @HiyashiChuka for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8640 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @HiyashiChuka and @Mariatta, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 46ebe61c7f3511b97268b44d5373a9e9cf0b5cc7 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2018
(cherry picked from commit 46ebe61)

Co-authored-by: HiyashiChuka <[email protected]>
@Mariatta Mariatta removed their assignment Aug 3, 2018
@Mariatta
Copy link
Member

Mariatta commented Aug 3, 2018

Thanks @HiyashiChuka and congrats on your first contribution to CPython 🌮

miss-islington added a commit that referenced this pull request Aug 3, 2018
(cherry picked from commit 46ebe61)

Co-authored-by: HiyashiChuka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir OS-windows skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants