bpo-34047: IDLE: fix mousewheel scrolling direction on macOS #8678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
added
type-bug
terryjreedy
requested changes
Aug 6, 2018
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
As explained on the issue, the correction exposed more bugs. I am rewriting the function and will improve the doctest.
terryjreedy
approved these changes
Aug 6, 2018
Member
|
Approved pending htest or equivalent passing on Mac by scrolling 'correctly' for Mac. |
Contributor
Author
|
@terryjreedy, I tested this on my mac, both in IDLE proper and the htest, and all looks working as expected. I specifically checked that scroll direction is consistent with the rest of the OS with system setting "Scroll direction: Natural" either on or off. |
Contributor
|
Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-8723 is a backport of this pull request to the 3.7 branch. |
|
GH-8724 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2018
…H-8678) (cherry picked from commit 077059e) Co-authored-by: Tal Einat <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2018
…H-8678) (cherry picked from commit 077059e) Co-authored-by: Tal Einat <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 10, 2018
(cherry picked from commit 077059e) Co-authored-by: Tal Einat <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Aug 10, 2018
(cherry picked from commit 077059e) Co-authored-by: Tal Einat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Vlad Tudorache for discovering the cause of the bug!
https://bugs.python.org/issue34047