Skip to content

bpo-34392: Add sys. _is_interned() #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 11 commits into from
Dec 4, 2023
Merged

bpo-34392: Add sys. _is_interned() #8755

serhiy-storchaka merged 11 commits into from
Dec 4, 2023

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 13, 2018 •
edited
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Aug 13, 2018
pablogsal
pablogsal reviewed Aug 13, 2018
View reviewed changes
Python/sysmodule.c
sys_isinterned_impl(PyObject *module, PyObject *string)
/*[clinic end generated code: output=0364c3f36499f868 input=2fe09bef8edf732e]*/
{
return PyUnicode_CHECK_INTERNED(string);
Copy link
Member

@pablogsal pablogsal Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Currently sys.internmakes a PyUnicode_CheckExact(s) over the string so interning a subclass of a string gives a TypeError back. This returns False. Does it make sense to do a exact check to mirror the interface of sys.intern?

Copy link
Member Author

@serhiy-storchaka serhiy-storchaka Aug 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.

@csabella
Copy link
Contributor

csabella commented May 25, 2020

@methane, should this be merged after fixing the merge conflicts? Thanks!

@methane methane changed the title bpo-34392: Add sys.isinterned(). bpo-34392: Add sys. _is_interned() May 26, 2020
@methane
Copy link
Member

methane commented May 26, 2020

@methane, should this be merged after fixing the merge conflicts? Thanks!

Up to @serhiy-storchaka. He wanted this API to write some tests.

iritkatriel
iritkatriel previously requested changes Nov 25, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

bedevere-bot commented Nov 25, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Dec 4, 2023

I have made the requested changes; please review again.

@serhiy-storchaka serhiy-storchaka dismissed iritkatriel’s stale review December 4, 2023 09:06

Merge conflicts are resolved.

@serhiy-storchaka serhiy-storchaka merged commit dee7bee into python:main Dec 4, 2023
@serhiy-storchaka serhiy-storchaka deleted the sys-isinterned branch December 4, 2023 09:09
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
bpo-34392: Add sys. _is_interned() (pythonGH-8755)
281b771
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
bpo-34392: Add sys. _is_interned() (pythonGH-8755)
e3ec71e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@pablogsal pablogsal pablogsal left review comments

@iritkatriel iritkatriel iritkatriel left review comments

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@serhiy-storchaka @csabella @methane @bedevere-bot @iritkatriel @pablogsal @the-knights-who-say-ni @ezio-melotti