Skip to content

bpo-34485: Fix pymain_read_conf() LC_ALL locale #9041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Sep 3, 2018
Merged

bpo-34485: Fix pymain_read_conf() LC_ALL locale #9041

vstinner merged 1 commit into from
Sep 3, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 3, 2018 •
edited by bedevere-bot
Loading

On some FreeBSD, nl_langinfo(CODESET) fails if LC_ALL or LC_CTYPE is
set to an invalid locale name. Replace _Py_SetLocaleFromEnv(LC_CTYPE)
with _Py_SetLocaleFromEnv(LC_ALL) to initialize properly locales.

https://bugs.python.org/issue34485

@vstinner
bpo-34544: Fix setlocale() in pymain_read_conf()
1780c84 
bpo-34485, bpo-34544: On some FreeBSD, nl_langinfo(CODESET) fails if
LC_ALL or LC_CTYPE is set to an invalid locale name. Replace
_Py_SetLocaleFromEnv(LC_CTYPE) with _Py_SetLocaleFromEnv(LC_ALL) to
initialize properly locales.

Partially revert commit 177d921.
@vstinner vstinner merged commit f01b2a1 into python:master Sep 3, 2018
@vstinner vstinner deleted the lc_all branch September 3, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot