[3.6] bpo-34575: Build with only VS2015 on AppVeyor #9066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently having caching issues between the two images, and VS2017 builds are tested by VSTS. Removing that one here will significantly decrease the time that AppVeyor builds take on this branch.
zware
changed the title
zware
changed the title
Member
|
"bedevere/issue-number — No issue # in title or "skip issue" label found" stupid bot |
vstinner
approved these changes
Sep 5, 2018
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
According to @zware there is a VS2017 buildbot, so I don't think that it matters to check VS2017 as pre-commit. This change should make AppVeyor twice faster on 3.6 which is a good thing, since AppVeyor is currently the slowest pre-commit CI on PRs.
zware
changed the title
zware
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34575