Skip to content

[3.6] bpo-34563: Fix for invalid assert on big output of multiprocessing.Process (GH-9027) #9069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 5 commits into from
Sep 7, 2018
Merged

[3.6] bpo-34563: Fix for invalid assert on big output of multiprocessing.Process (GH-9027) #9069

vstinner merged 5 commits into from
Sep 7, 2018

Conversation

@ahcub
Copy link
Contributor

@ahcub ahcub commented Sep 5, 2018 •
edited by bedevere-bot
Loading

ahcub added 2 commits September 5, 2018 04:23
@ahcub
[3.6] bpo-34563: Fix for invalid assert on big output of multiprocess…
3eb1eed 
…ing.Process (pythonGH-9027)

Fix for invalid assert on big output of multiprocessing.Process.

(cherry picked from commit 266f490)
@ahcub
remove parts that are not from the multiprocessing fix
893deb2
@bedevere-bot bedevere-bot mentioned this pull request Sep 5, 2018
Merged
@tirkarthi
Copy link
Member

tirkarthi commented Sep 5, 2018

Just as an update Appveyor build failure is tracked here : https://bugs.python.org/issue34575

Thanks

@ahcub
Copy link
Contributor Author

ahcub commented Sep 5, 2018

can we trigger something like clean rebuild for AppVeyor?

@tirkarthi
Copy link
Member

tirkarthi commented Sep 5, 2018

There is a REST API to clear the cache manually. I have added this at https://bugs.python.org/msg324613 . Maybe someone with credentials can try to see if it helps.

Ref : appveyor/ci#985

Thanks

@vstinner
Copy link
Member

vstinner commented Sep 5, 2018

AppVeyor hits https://bugs.python.org/issue34575 bug

@ahcub
Copy link
Contributor Author

ahcub commented Sep 7, 2018

is there anything I can do to help to get this PR merged?

@tirkarthi
Copy link
Member

tirkarthi commented Sep 7, 2018 •
edited
Loading

VS2017 that was causing build failure was removed as per the linked issue for Python 3.6 in Appveyor. Since it's a backport I think a rebuild trigger by someone with access will work fine.

Thanks

@vstinner vstinner merged commit 23f427a into python:3.6 Sep 7, 2018
@vstinner
Copy link
Member

vstinner commented Sep 7, 2018

The AppVeyor is currently not mandatory. I'm quite sure that the fix is good, and we have post-commit tests using buildbots on 3.6, so I merged your PR.

@ahcub
Copy link
Contributor Author

ahcub commented Sep 7, 2018 •
edited
Loading

awesome, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahcub @tirkarthi @vstinner @the-knights-who-say-ni @bedevere-bot