Skip to content

bpo-28617 Fixed docs inaccuracies about the types that support membership tests #9086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 3 commits into from
Sep 11, 2018
Merged

bpo-28617 Fixed docs inaccuracies about the types that support membership tests #9086

miss-islington merged 3 commits into from
Sep 11, 2018

Conversation

@wimglenn
Copy link
Contributor

@wimglenn wimglenn commented Sep 7, 2018 •
edited
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 7, 2018
@Mariatta Mariatta self-assigned this Sep 11, 2018
@miss-islington miss-islington merged commit 08bcf64 into python:master Sep 11, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2018

Thanks @wimglenn for the PR, and @miss-islington for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2018

GH-9171 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2018
@wimglenn @miss-islington
bpo-28617 Fixed docs inaccuracies about the types that support member…
3737b40 
…ship tests (pythonGH-9086)

<!-- issue-number: [bpo-28617](https://www.bugs.python.org/issue28617) -->
https://bugs.python.org/issue28617
<!-- /issue-number -->
(cherry picked from commit 08bcf64)

Co-authored-by: wim glenn <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2018

GH-9172 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2018
@wimglenn @miss-islington
bpo-28617 Fixed docs inaccuracies about the types that support member…
9d30e4f 
…ship tests (pythonGH-9086)

<!-- issue-number: [bpo-28617](https://www.bugs.python.org/issue28617) -->
https://bugs.python.org/issue28617
<!-- /issue-number -->
(cherry picked from commit 08bcf64)

Co-authored-by: wim glenn <[email protected]>
miss-islington added a commit that referenced this pull request Sep 11, 2018
@miss-islington @wimglenn
bpo-28617 Fixed docs inaccuracies about the types that support member…
3e648f8 
…ship tests (GH-9086)

<!-- issue-number: [bpo-28617](https://www.bugs.python.org/issue28617) -->
https://bugs.python.org/issue28617
<!-- /issue-number -->
(cherry picked from commit 08bcf64)

Co-authored-by: wim glenn <[email protected]>
miss-islington added a commit that referenced this pull request Sep 11, 2018
@miss-islington @wimglenn
bpo-28617 Fixed docs inaccuracies about the types that support member…
889f080 
…ship tests (GH-9086)

<!-- issue-number: [bpo-28617](https://www.bugs.python.org/issue28617) -->
https://bugs.python.org/issue28617
<!-- /issue-number -->
(cherry picked from commit 08bcf64)

Co-authored-by: wim glenn <[email protected]>
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Sep 11, 2018

@Mariatta, why the bot merges in the master branch? The discussion about this issue is not finished yet.

@mariatta-bot
Copy link

mariatta-bot commented Sep 11, 2018

Mariatta was mentioned, but she's out of open source for the rest of September 2018. Be aware she might not get to this until October 2018.
(I'm a bot)

@wimglenn wimglenn deleted the issue28617 branch September 11, 2018 18:43
@Mariatta
Copy link
Member

Mariatta commented Sep 11, 2018

@serhiy-storchaka I did not see further discussions about it. I've notified people in python/bedevere#14 (comment) and zulip (https://python.zulipchat.com/#narrow/stream/116501-workflow/topic/Automerge.20bot)

In addition, if people prefer to not automerge, they can still do that, just don't add the automerge label.

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Sep 11, 2018

I left a comment on the tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freddrake freddrake freddrake approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees

@Mariatta Mariatta

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wimglenn @miss-islington @bedevere-bot @serhiy-storchaka @mariatta-bot @Mariatta @freddrake @the-knights-who-say-ni