gh-92049: Forbid pickling constants re._constants.SUCCESS etc #92070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, pickling did not fail, but the result could not be unpickled.
serhiy-storchaka
added
type-bug
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
Contributor
|
Sorry @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 30, 2022
…S etc (pythonGH-92070) Previously, pickling did not fail, but the result could not be unpickled.. (cherry picked from commit 6d0d547) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-92073 is a backport of this pull request to the 3.10 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 30, 2022
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 1, 2022
…SUCCESS etc (pythonGH-92070) (pythonGH-92073) Previously, pickling did not fail, but the result could not be unpickled. (cherry picked from commit 6d0d547) (cherry picked from commit e8ff3c9) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
May 1, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
… etc (pythonGH-92070) (pythonGH-92073) (pythonGH-92102) Previously, pickling did not fail, but the result could not be unpickled. (cherry picked from commit 6d0d547) (cherry picked from commit e8ff3c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pickling did not fail, but the result could not be unpickled.