Skip to content

bpo-34582: Adds JUnit XML output for regression tests #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zooba merged 17 commits into from
Sep 18, 2018
Merged

bpo-34582: Adds JUnit XML output for regression tests #9210

zooba merged 17 commits into from
Sep 18, 2018

Conversation

@zooba
Copy link
Member

@zooba zooba commented Sep 12, 2018 •
edited by bedevere-bot
Loading

@zooba zooba added tests Tests in the Lib/test dir DO-NOT-MERGE labels Sep 12, 2018
@zooba zooba changed the title Adds JUnit XML output for regression tests bpo-34582: Adds JUnit XML output for regression tests Sep 14, 2018
@zooba zooba closed this Sep 14, 2018
@zooba zooba reopened this Sep 14, 2018
zware
zware reviewed Sep 14, 2018
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, with a question and some discussion that doesn't need to go anywhere. I do think @vstinner should have a look at this before it goes in, as he's most intimately familiar with libregrtest.

@zooba zooba requested a review from vstinner September 14, 2018 23:01
@zooba
Copy link
Member Author

zooba commented Sep 17, 2018

@vstinner Any interest in looking this over? Or should I just merge?

@zooba zooba merged commit d0f49d2 into python:master Sep 18, 2018
@zooba zooba deleted the junit-tests branch September 18, 2018 16:10
@zooba
Copy link
Member Author

zooba commented Sep 18, 2018

I'll wait for buildbot results before backporting.

@miss-islington
Copy link
Contributor

miss-islington commented Sep 18, 2018

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 18, 2018

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 18, 2018

GH-9401 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2018
@zooba @miss-islington
bpo-34582: Adds JUnit XML output for regression tests (pythonGH-9210)
e0a1b4b 
(cherry picked from commit d0f49d2)

Co-authored-by: Steve Dower <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2018
@zooba @miss-islington
bpo-34582: Adds JUnit XML output for regression tests (pythonGH-9210)
be3fa88 
(cherry picked from commit d0f49d2)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Sep 18, 2018

GH-9402 is a backport of this pull request to the 3.6 branch.

zooba added a commit that referenced this pull request Sep 18, 2018
@miss-islington @zooba
bpo-34582: Adds JUnit XML output for regression tests (GH-9210)
1a89cb5 
(cherry picked from commit d0f49d2)

Co-authored-by: Steve Dower <[email protected]>
zooba added a commit that referenced this pull request Sep 18, 2018
@miss-islington @zooba
bpo-34582: Adds JUnit XML output for regression tests (GH-9210)
c927649 
(cherry picked from commit d0f49d2)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @miss-islington @bedevere-bot @zware @the-knights-who-say-ni