Skip to content

[2.7] bpo-28994: Remove mistakenly backported atexitmodule.c #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Sep 12, 2018
Merged

[2.7] bpo-28994: Remove mistakenly backported atexitmodule.c #9214

serhiy-storchaka merged 2 commits into from
Sep 12, 2018

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Sep 12, 2018 •
edited by bedevere-bot
Loading

It was backported in 0cc43df.

I believe the test added in that commit can stay, however.

https://bugs.python.org/issue28994

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Sep 12, 2018

Good catch! Maybe remove also the NEWS entry?

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Sep 12, 2018

Good catch!

Someone had reported it at GH-2123.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news labels Sep 12, 2018
@orivej
Copy link
Contributor

orivej commented Sep 12, 2018

Thank you! Could you also remove Objects/bytesobject.c (here or in another PR), introduced in #4163. It was accidentally backported from an immaterially changed a231428#diff-aac9159c0ef71bb482b19ca5c07e2f3d

@serhiy-storchaka serhiy-storchaka merged commit b36567b into python:2.7 Sep 12, 2018
@Jackeloves
Copy link

Jackeloves commented Dec 2, 2018

路过。。。。

@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @serhiy-storchaka @orivej @Jackeloves @the-knights-who-say-ni @bedevere-bot