[3.7] bpo-40548: Fix "Check for source changes (pull_request)" GH Action job (GH-21806) #92342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonGH-21806) On Git 2.28, "git diff master..." (3 dots) no longer works when "fetch --depth=1" is used, whereas it works on Git 2.26. Replace "..." (3 dots) with ".." (2 dots) in the "git diff" command computing the list of modified files between the base branch and the PR branch. (cherry picked from commit eaa5517) Co-authored-by: Victor Stinner <[email protected]>
Contributor
Author
|
@vstinner: Status check is done, and it's a success ✅ . |
JelleZijlstra
approved these changes
May 5, 2022
Member
|
Why do you need this backport today? |
Member
|
See #92334 |
Contributor
Author
|
@vstinner: Status check is done, and it's a failure ❌ . |
1 similar comment
Contributor
Author
|
@vstinner: Status check is done, and it's a failure ❌ . |
Contributor
|
Do we still want to pursue this in the 3.7 branch? |
Member
Sorry, this should have been merged earlier; it slipped off my radar. Thanks for the backport! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Git 2.28, "git diff master..." (3 dots) no longer works when
"fetch --depth=1" is used, whereas it works on Git 2.26.
Replace "..." (3 dots) with ".." (2 dots) in the "git diff" command
computing the list of modified files between the base branch and the
PR branch.
(cherry picked from commit eaa5517)
Co-authored-by: Victor Stinner [email protected]