Skip to content

Link to the devguide's PR guidelines #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brettcannon merged 1 commit into from
Mar 31, 2017
Merged

Link to the devguide's PR guidelines #932

brettcannon merged 1 commit into from
Mar 31, 2017

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 31, 2017

No description provided.

@brettcannon brettcannon added the docs Documentation in the Doc dir label Mar 31, 2017
@brettcannon brettcannon self-assigned this Mar 31, 2017
Mariatta
Mariatta reviewed Mar 31, 2017
View reviewed changes
.github/CONTRIBUTING.rst
in pull requests using the format of ``bpo-12345`` . If your pull request is in
response to a specific issue then please mention it in the title,
e.g. “bpo-12345: fix comment in tokenizer.c”.
project. Details on how to properly submit a pull request are covered in
Copy link
Member

@Mariatta Mariatta Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would omit the word 'properly' . 🤔

Copy link
Member

@Mariatta Mariatta Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm too picky. It's up to you. Looks good overall. :) Thanks.

Copy link
Member Author

@brettcannon brettcannon Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I put that word in to make sure people read it, otherwise submitting a PR without following those guidelines won't lead to your PR being accepted outright, hence not done properly.

@brettcannon brettcannon merged commit 1e5766f into master Mar 31, 2017
@brettcannon brettcannon deleted the pr-guidelines branch March 31, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta left review comments

Assignees

@brettcannon brettcannon

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettcannon @Mariatta @the-knights-who-say-ni