Doc: Disable smartquotes for zh-tw and fr translations. #9337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@adrianliaw can you please test a build with this patch and validate it fixes zh-tw quote issues? |
JulienPalard
changed the title
Contributor
|
It works perfectly for our build. Thank you @JulienPalard for the PR! As a side note, previously the issue occurred in the translation of tutorial/venv.rst where: was translated into: but output as Now by applying this PR, this issue doesn't raise again. |
willingc
approved these changes
Sep 18, 2018
Contributor
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
Looks good. Thanks @JulienPalard. I'll leave this for you to merge.
Member
Author
|
I prefer the #9423 version, so I close mine. |
adrianliaw
added a commit
to adrianliaw/cpython
that referenced
this pull request
Oct 11, 2018
This is a replacement for python#9337. * Using conf.py to disable smartquotes through Sphinx instead of using docutils.conf * Disable smartquotes for Japanese, French and Traditional Chinese translations See: * Suggesting to use conf.py: https://mail.python.org/pipermail/doc-sig/2018-September/004084.html * Original smartquotes issue in ja translations: https://bugs.python.org/issue31793 * Disabling for ja: python#4006 * Smartquotes issue in fr: python/python-docs-fr#303 * Smartquotes issue in zh_TW: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
and: #4006