bpo-25711: Move _ZipImportResourceReader from importlib to zipimport. #9406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warsaw
approved these changes
Sep 18, 2018
Member
warsaw
left a comment
warsaw
left a comment
There was a problem hiding this comment.
I don't see where it's removed from the importlib source, but maybe I'm missing it. Other than that, this looks good.
serhiy-storchaka
force-pushed
the
zipimport-resource-reader
branch
from
0164bf0 to
c734452
Compare
Member
Author
|
Oh, I forgot to save these changes. Thank you for noticing this. Updated. |
warsaw
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue25711