Add helpful explaination to test_password_manager tests. (#936) #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uncomment and fix a path test. (cherry picked from commit 1f5425f)
Member
Author
|
Not Backporting this change. The test for adding password manager passwords, stores it in the dictionary of realm. For the test-case where we mention the first one wins, the dictionary iteration order seems to matter. For 3.5, I think, we should remove the test which is currently commented. |
Member
Author
|
The above comment is for 3.5 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also uncomment and fix a path test.
(cherry picked from commit 1f5425f)