[3.11] gh-95231: Disable md5 & crypt modules if FIPS is enabled (GH-94742) #95999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nGH-94742) If kernel fips is enabled, we get permission error upon doing `import crypt`. So, if kernel fips is enabled, disable the unallowed hashing methods. Python 3.9.1 (default, May 10 2022, 11:36:26) [GCC 10.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import crypt Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3.9/crypt.py", line 117, in <module> _add_method('MD5', '1', 8, 34) File "/usr/lib/python3.9/crypt.py", line 94, in _add_method result = crypt('', salt) File "/usr/lib/python3.9/crypt.py", line 82, in crypt return _crypt.crypt(word, salt) PermissionError: [Errno 1] Operation not permitted Signed-off-by: Shreenidhi Shedi <[email protected]> (cherry picked from commit 2fa03b1) Co-authored-by: Shreenidhi Shedi <[email protected]>
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Member
|
@pablogsal Do you want the fix in 3.11.0 or should we wait until 3.11.1? Or keep it 3.12-only? |
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Member
I think this is ok for 3.11.0 👍 |
pablogsal
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If kernel fips is enabled, we get permission error upon doing
import crypt. So, if kernel fips is enabled, disable theunallowed hashing methods.
Python 3.9.1 (default, May 10 2022, 11:36:26)
[GCC 10.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
Signed-off-by: Shreenidhi Shedi [email protected]
(cherry picked from commit 2fa03b1)
Co-authored-by: Shreenidhi Shedi [email protected]