bpo-34871: inspect: Don't pollute sys.modules

[methane]

https://bugs.python.org/issue34871

[1st1]

I don't like the idea to copy sys.modules. It's an expensive operation, and this code is executed to evaluate every parameter with a non-trivial default for a function with __text_signature__.

Looking at the documentation of Argument Clinic, I see that this code is supposed to handle simple defaults like mod.attr.

So why don't we rewrite wrap_value to do just that, e.g.:

    def wrap_value(s):
        try:
            value = eval(s, module_dict)
        except NameError:
            match = re.match(r'\s*(?P<mod>\w+)\.(?P<attr>\w+)\s*', s)
            if not match:
                raise RuntimeError

            mod = sys.modules.get(match.group('mod'))
            if mod is None:
                raise RuntimeError
            try:
                value = getattr(mod, match.group('attr'))
            except AttributeError:
                raise RuntimeError

This code is equivalent to the previous code and doesn't use eval() at all for evaluating non-trivial defaults.

[bedevere-bot]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[methane]

I don't like the idea to copy sys.modules. It's an expensive operation, and this code is executed to evaluate every parameter with a non-trivial default for a function with __text_signature__.

sys.modules is a plain dict. Copying a dict will be faster than regular expression.

[1st1]

sys.modules is a plain dict. Copying a dict will be faster than regular expression.

Depends on how many modules you have in your application. But your solution to copy it once works for me.

[miss-islington]

@methane: Status check is done, and it's a success ✅ .

[miss-islington]

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

[bedevere-bot]

GH-9701 is a backport of this pull request to the 3.7 branch.

[bedevere-bot]

GH-9702 is a backport of this pull request to the 3.6 branch.