GH-82448: Add thread timeout for loop.shutdown_default_executor #97561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
kumaraditya303
force-pushed
the
bpo-38267-shutdown_default_executor-timeout
branch
from
ef3e42b to
7216b1d
Compare
kumaraditya303
force-pushed
the
bpo-38267-shutdown_default_executor-timeout
branch
from
7216b1d to
4db9e1d
Compare
kumaraditya303
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 1e15936 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
|
@kumaraditya303 Can you respond to my review, so we can land this? |
…67-shutdown_default_executor-timeout
gvanrossum
approved these changes
Sep 28, 2022
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM, I'll merge one nit and then land.
gvanrossum
reviewed
Sep 28, 2022
Misc/NEWS.d/next/Library/2019-09-25-00-37-51.bpo-38267.X9Jb5V.rst
Outdated
Show resolved
Hide resolved
kumaraditya303
deleted the
bpo-38267-shutdown_default_executor-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Kyle Stanley [email protected]
Closes #82448