Skip to content

GH-90352: fix _SelectorDatagramTransport to inherit from DatagramTransport #98844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 2 commits into from
Oct 29, 2022
Merged

GH-90352: fix _SelectorDatagramTransport to inherit from DatagramTransport #98844

gvanrossum merged 2 commits into from
Oct 29, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Oct 29, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 29, 2022
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 29, 2022
Closed
@gvanrossum gvanrossum merged commit 9bdec0a into python:main Oct 29, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Oct 29, 2022

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 29, 2022

Sorry @kumaraditya303 and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 9bdec0aa4516650e51b998418fb6188427137fed 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2022
@kumaraditya303 @miss-islington
pythonGH-90352: fix _SelectorDatagramTransport to inherit from Datagr…
8faab1b 
…amTransport (pythonGH-98844)

(cherry picked from commit 9bdec0a)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2022

GH-98854 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 29, 2022
@gvanrossum
Copy link
Member

gvanrossum commented Oct 29, 2022

I wouldn’t backport this.

@gvanrossum gvanrossum removed the needs backport to 3.11 only security fixes label Oct 29, 2022
@kumaraditya303 kumaraditya303 deleted the datagram branch October 29, 2022 16:55
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 30, 2022
Closed
@arhadthedev arhadthedev mentioned this pull request Oct 30, 2022
Closed
mnixry added a commit to mnixry/vmess-aead-python that referenced this pull request Mar 27, 2024
@mnixry
🐛 ♻️ Refactor CLI server to fix datagram transport bug
cf2cfd3 
ref: python/cpython#98844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@gvanrossum gvanrossum

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong base class for transport returned by loop.create_datagram_endpoint()

4 participants

@kumaraditya303 @miss-islington @bedevere-bot @gvanrossum