Skip to content

Conversation

@Mariatta
Copy link
Member

Remove the part about merging into master.
Remove the part about prefixing the PR title with X.Y, cherry_picker.py already does this.

Closes #173

Remove the part about merging into master.
Remove the part about prefixing the PR title with `X.Y`, cherry_picker.py already does this.

Closes #173
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Mariatta. One small question.

committing.rst Outdated

Backporting changes to Python 3.6 (or older version)
----------------------------------------------------
Backporting Changes to Older Version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mariatta: Should there be an an before Older Version?

@Mariatta
Copy link
Member Author

Thanks :) Updated.

@willingc willingc merged commit 8f44690 into master Apr 25, 2017
@Mariatta Mariatta deleted the issue-173 branch April 25, 2017 17:33
@berkerpeksag
Copy link
Member

I think the part about prefixing PR title should stay for now. Not every core dev use cherry_picker.py yet :)

@willingc
Copy link
Collaborator

A reasonable comment during the transition @berkerpeksag. Perhaps adding a small note about prefixing the PR title and marking it "legacy process" and the cherry_picker.py as the "preferred process".

@Mariatta thoughts?

@Mariatta
Copy link
Member Author

Sounds reasonable :) I'm reviewing the other PR now, and will add back the PR prefix after.

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
* Update backport instructions

Remove the part about merging into master.
Remove the part about prefixing the PR title with `X.Y`, cherry_picker.py already does this.

Closes python#173

* hash -> hashes

* add `an`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the section about backporting changes

5 participants