PEP 698: Add __override__ flag to runtime behavior
#2855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided to add this for two reasons: - It was specifically requested by the author of the `overrides` library, because there there are some handy runtime uses of override information (such as propagating docstrings, which we highlight as a concrete example) - We realized that we actually added `__final__` to `@typing.final` in spite of it not being specified in PEP 591, which we felt strongly suggests that even if we omit it we would later change our minds. This runtime behavior is currently implemented in typing_extensions (see python/typing_extensions#86) as well as pyre_extensions.
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to add this for two reasons:
overrideslibrary, because there there are some handy runtime uses of override information (such as propagating docstrings, which we highlight as a concrete example)__final__to@typing.finalin spite of it not being specified in PEP 591, which we felt strongly suggests that even if we omit it we would later change our minds.This runtime behavior is currently implemented in typing_extensions (see python/typing_extensions#86) as well as pyre_extensions.
I ran
pre-commit, it looks like there are no lint errors