Skip to content

Revert "Issue #21: Avoid C++ keyword module (#22)" #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Mar 29, 2022
Merged

Revert "Issue #21: Avoid C++ keyword module (#22)" #28

vstinner merged 1 commit into from
Mar 29, 2022

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Mar 29, 2022

This reverts commit ca6a60e.

@vstinner
Copy link
Member Author

vstinner commented Mar 29, 2022

The usage of the C++20 module keyword is not a problem in the Python C API: see https://bugs.python.org/issue39355#msg416257

cc @erlend-aasland

@erlend-aasland
Copy link

erlend-aasland commented Mar 29, 2022

Thanks!

@vstinner vstinner merged commit e137d72 into python:main Mar 29, 2022
@vstinner vstinner deleted the revert_module branch March 29, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @erlend-aasland