Mark sqlite3.Cursor.rowcount as an int
#6150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2021 13:10
DBAPI2 [specifies](https://www.python.org/dev/peps/pep-0249/#rowcount) that this is a "number" rather than specifically an int. It notes that a future version of the API might use `None` in place of `-1` to signal that there's no rowcount value to report. But that would presumably belong in a DBAPI version 3.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
DMRobertson
pushed a commit
to matrix-org/sydent
that referenced
this pull request
Jan 5, 2022
A version of mypy has been released which includes python/typeshed#6150. (Typeshed is vendored with mypy these days.) We can now remove the redundant cast.
DMRobertson
pushed a commit
to matrix-org/sydent
that referenced
this pull request
Jan 5, 2022
* Remove redunant casts A version of mypy has been released which includes python/typeshed#6150. (Typeshed is vendored with mypy these days.) We can now remove the redundant cast. * Mark logging handler as a generic logging handler. Since python/typeshed#5681 (vendored in recent mypy releases), StreamHandler is now generic over its stream. This causes us pain: > Missing type parameters for generic type "StreamHandler" And I couldn't find a satisfactory type parameter that worked here. - a `TimedRotatingFileHandler` instance is a `FileHandler` which is a `StreamHandler[TextIOWrapper]`. - the instance `StreamHandler()` (which writes to stdout) is overloaded to be a `StreamHandler[TextIO]` `handler: StreamHandler[TextIO]` didn't work. I don't fully understand the difference between the concrete TextIOWrapper and the abstract TextIO (the former looks to be compatible with the latter?). I think the StreamHandler type parameter would need to be covariant for this to work. In any case, we're not making use of any of the stream or file specific attributes here. So let's just mark it as a general `Handler`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBAPI2 specifies that this is a "number" rather than specifically an int, but I think everyone expects this to be an int! It notes that a future version of the API might use
Nonein place of-1to signal that there's norowcountvalue to report. But that would presumably belong in a DBAPI version 3.Some more justification: CPython's implemention of this is written in C. It uses a
longto store the rowcount.Sorry for not going further here and adding more comprehensive typing!