Skip to content

Bump various test dependencies #9646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 6 commits into from
Feb 1, 2023
Merged

Bump various test dependencies #9646

JelleZijlstra merged 6 commits into from
Feb 1, 2023

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Feb 1, 2023

No description provided.

@AlexWaygood AlexWaygood mentioned this pull request Feb 1, 2023
Closed
@srittau
Copy link
Collaborator

srittau commented Feb 1, 2023 •
edited
Loading

Could we put the black reformats into a separate PR? Remember that the commit message becomes a changelog entry for third-party stubs. (Something I always forget when merging.)

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Feb 1, 2023

Could we put the black reformats into a separate PR? Remember that the commit message becomes a changelog entry for third-party stubs. (Something I always forget when merging.)

Yes, makes sense

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood commented Feb 1, 2023
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Feb 1, 2023 •
edited
Loading

The third-party stubtest failure in beautifulsoup has already been noted in #9645, and is unrelated to this PR.

The changes to builtins.BaseExceptionGroup.__init__ and builtins.ExceptionGroup.__init__ are needed to satisfy a new pyright lint: see https://github.com/python/typeshed/actions/runs/4063554162/jobs/6995928535. These methods are actually overridden at runtime, from what I can see, so it seems fine to override them in the stub as well: https://github.com/python/cpython/blob/75227fba1dd1683289d90ada7abba237bff55d14/Objects/exceptions.c#L808-L819

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 8000fbd into main Feb 1, 2023
@JelleZijlstra JelleZijlstra deleted the bump-deps branch February 1, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood @srittau @JelleZijlstra