Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Mar 30, 2023

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

werkzeug (https://github.com/pallets/werkzeug)
+ src/werkzeug/routing/map.py:763: error: Unused "type: ignore[type-var]" comment
+ src/werkzeug/routing/map.py:764: error: Argument 1 to "urlunsplit" has incompatible type "Tuple[str, str, str, Union[Mapping[str, Any], str, None], None]"; expected "Iterable[None]"  [arg-type]

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, werkzeug error looks clearer (also I think the code might be genuinely buggy if someone passes empty dict)

Note, since we're caring more about the IDE setting now, this annotation will be a little less helpful, but I'm fine with it.

@AlexWaygood AlexWaygood merged commit 88a9e90 into python:main Apr 2, 2023
@AlexWaygood AlexWaygood deleted the urlparse branch April 2, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants