Improve urlunsplit and urlunparse
#9991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlunsplitandurlunparseis currently pointless. If you provide a tuple of a different length to these functions, type checkers simply fall back to the second overload, and don't emit an error: https://mypy-play.net/?mypy=latest&python=3.11&gist=966b9d881ce16ee67e220bff46d5f21c.strforurlunsplit((None, None, None, None, None)), but the returned value isb"": https://mypy-play.net/?mypy=latest&python=3.11&gist=dffd33f24d5e90b18cee1757d48149c6. Replace the first overload with an overload forIterable[None].Iterableinstead ofSequence, since these functions accept any iterable that can be unpacked; it doesn't have to be a sequence.