Use collections.abc.Reversible if it exists #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if it exists. Also if it exists Reversible is a subclass of Iterable, and Sequence is subclass of Reversible.
Member
|
I don't think that CPython issue has been fixed, so this is just a fantasy, right? I just put a new message in there asking Andrew if he's still interested. |
Member
Author
|
@gvanrossum I decided not to wait for Andrew and submitted a patch for http://bugs.python.org/issue25987 following his proposal. |
Reversible is not always a protocol (it is a generic ABC if collections.abc.Reversible exists), but SupportsAbs is always a protocol.
Again, Reversible could not be a protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172 . I assumed that if Reversible is present in collections.abc then it means that http://bugs.python.org/issue25987 is resolved as Andrew Barnert proposes (as I understand @gvanrossum agrees with this), i.e., Sequence is subclass of Reversible, and not directly of Iterable.