Change the default null value for timestamps
#16481
Conversation
As per discussion, this changes the model generators to specify `null: false` for timestamp columns. A warning is now emitted if `timestamps` is called without a `null` option specified, so we can safely change the behavior when no option is specified in Rails 5.
|
Not sure how this can be safe unless old migrations are updated as well? They'll be implicitly |
|
That's the goal behind the deprecation warning if it is unspecified, users will need to specify |
|
The deprecation warning will come too late though, after the migration already ran on the production db. |
|
The warning would also appear any time anyone did anything related to |
Change the default `null` value for timestamps
|
This deprecation only pertains to the |
- Use unscoped when referring to Site to remove the deleted_at column in SQL queries built by ActiveRecord. - Add :null => false to all timestamps definitions. Default changed from Rails 3.2 to 4.0. See rails/rails#16481
Fix Rails 5 deprecation warning for not explicitly setting the null option for timestamps. Also moved other timestamps to use timestamps method This deprecation warning was introduced in rails/rails#16481
Fix Rails 5 deprecation warning for not explicitly setting the null option for timestamps. Also moved other timestamps to use timestamps method This deprecation warning was introduced in rails/rails#16481
5 participants
As per discussion, this changes the model generators to specify
null: falsefor timestamp columns. A warning is now emitted iftimestampsis called without anulloption specified, so we cansafely change the behavior when no option is specified in Rails 5.