Introduce after_{create,update,delete}_commit callbacks #22516
Merged
+63
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @senny (@rails-bot has picked a reviewer for you, use r? to override) |
gsamokovarov
force-pushed
the
after-create-update-destroy-commit
branch
2 times, most recently
from
2cbd5d2 to
76ed730
Compare
Those are actually shortcuts for `after_commit`.
Before:
after_commit :add_to_index_later, on: :create
after_commit :update_in_index_later, on: :update
after_commit :remove_from_index_later, on: :destroy
After:
after_create_commit :add_to_index_later
after_update_commit :update_in_index_later
after_destroy_commit :remove_from_index_later
gsamokovarov
force-pushed
the
after-create-update-destroy-commit
branch
from
76ed730 to
5a300b2
Compare
Member
|
Lovely! You're fast 👌 |
dhh
pushed a commit
that referenced
this pull request
Dec 6, 2015
…oy-commit
Introduce after_{create,update,delete}_commit callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are actually shortcuts for
after_commit.Before:
After:
Fixes #22515.