Deprecate {insert|update|delete}_sql in DatabaseStatements
#23086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @chancancode (@rails-bot has picked a reviewer for you, use r? to override) |
Member
Author
|
In Rails 3.0, Currently I think that we don't use |
Member
|
Could you add a CHANGELOG entry? |
kamipo
force-pushed
the
deprecate_insert_update_delete_sql
branch
2 times, most recently
from
4c694cd to
26262a4
Compare
Member
Author
|
I added a CHANGELOG entry! |
Member
|
Needs a deprecation test? |
kamipo
force-pushed
the
deprecate_insert_update_delete_sql
branch
9 times, most recently
from
1a0f7fd to
edf289e
Compare
kamipo
force-pushed
the
deprecate_insert_update_delete_sql
branch
3 times, most recently
from
73dc026 to
7da8d51
Compare
kamipo
force-pushed
the
deprecate_insert_update_delete_sql
branch
2 times, most recently
from
3850869 to
cdf5724
Compare
kamipo
force-pushed
the
deprecate_insert_update_delete_sql
branch
4 times, most recently
from
c703d7c to
87987f7
Compare
Originally, `{insert|update|delete}_sql` is protected methods.
We can use the `{insert|update|delete}` public methods instead.
kamipo
force-pushed
the
deprecate_insert_update_delete_sql
branch
from
87987f7 to
6b937bb
Compare
Member
Author
|
Added a deprecation test. |
rafaelfranca
added a commit
that referenced
this pull request
Mar 2, 2016
Deprecate `{insert|update|delete}_sql` in `DatabaseStatements`
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally,
{insert|update|delete}_sqlis protected methods.We can use the
{insert|update|delete}public methods instead.https://github.com/rails/rails/blob/v5.0.0.beta1/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb#L378-L392