Support Promise cancellation for all connectors #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2016
Contributor
Author
|
Updated to fix errors on legacy PHP versions, now ready for review |
WyriHaximus
approved these changes
Nov 15, 2016
Contributor
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
LGTM except the fact that tests for HHVM are failing
cboden
approved these changes
Nov 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now register a Promise cancellation handler so that the following code actually cleans up the underlying socket resource:
Closes #40