Skip to content

Conversation

@clue
Copy link
Contributor

@clue clue commented Nov 15, 2016

This is not a BC break because the undocumented(!) SecureStream extends the Stream class.

@clue clue added this to the v0.5.2 milestone Nov 16, 2016
@clue clue changed the title [WIP] Replace SecureStream with unlimited read buffer from react/stream v0.4.5 Replace SecureStream with unlimited read buffer from react/stream v0.4.5 Dec 5, 2016
@clue
Copy link
Contributor Author

clue commented Dec 5, 2016

Rebased now that #51 is in and removed the WIP marker because this is now ready for merge IMO :shipit:

Copy link
Contributor

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@clue clue merged commit 223e0a3 into reactphp-legacy:master Dec 19, 2016
@clue clue deleted the wrap branch December 19, 2016 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants