Skip to content

Conversation

@clue
Copy link
Member

@clue clue commented Jun 29, 2018

This PR adds a new resolveAll($domain, $type) method which supports sending custom query types, such as AAAA queries. This allows you to query all known query types (see #31) and is also the prerequisite for IPv6 lookups in our Socket component (reactphp/socket#116) as discussed in #43.

$resolver->resolveAll('reactphp.org', Message::TYPE_A)->then(function ($ips) {
    echo 'IPv4 addresses for reactphp.org ' . implode(', ', $ips) . PHP_EOL;
});

$resolver->resolveAll('reactphp.org', Message::TYPE_AAAA)->then(function ($ips) {
    echo 'IPv6 addresses for reactphp.org ' . implode(', ', $ips) . PHP_EOL;
});

Supersedes / closes #67, thank you @WyriHaximus!
Resolves / closes #43
Builds on top of #109

@clue clue added this to the v0.4.15 milestone Jun 29, 2018
@WyriHaximus WyriHaximus requested a review from jsor June 29, 2018 07:05
@jsor jsor merged commit c85119c into reactphp:master Jun 29, 2018
@clue clue deleted the resolveall branch June 29, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] API design for IPv6 and more types of records

3 participants