Optionally accept explicit udp:// and tcp:// scheme in Factory #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Factory defaults to creating a UDP-based executor-stack. One can now explicitly specify the tcp:// URI scheme in order force using the new TCP-based executor stack. In a follow-up changeset, the default will be changed to automatic transport protocol detection and the explicit choice will mostly exist for rare special cases and debugging purposes.
jsor
approved these changes
Aug 9, 2019
WyriHaximus
approved these changes
Aug 10, 2019
This was referenced Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Factory defaults to creating a UDP-based executor-stack. One can now
explicitly specify the tcp:// URI scheme in order force using the new
TCP-based executor stack. In a follow-up changeset, the default will be
changed to automatic transport protocol detection (#19) and the explicit
choice will mostly exist for rare special cases and debugging purposes.
Builds on top of #145
Refs #19
Refs #5